RFR: 8254566: Clarify the spec of ClassLoader::getClassLoadingLock for non-parallel capable loader [v2]

David Holmes dholmes at openjdk.org
Fri Jun 30 01:15:53 UTC 2023


On Fri, 30 Jun 2023 00:22:13 GMT, Mandy Chung <mchung at openjdk.org> wrote:

>> The spec of `ClassLoader::getClassLoadingLock` is unclear that this method is intended for parallel-capable class loader implementations to provide an alternate implementation.   For non-parallel-capable class loaders, this method should return this `ClassLoader` object.   The javadoc uses "the default implementation" which could be interpreted that non-parallel-capable class loaders can also override this implementation, which is not the intent.  See https://openjdk.org/groups/core-libs/ClassLoaderProposal.html.
>
> Mandy Chung has updated the pull request incrementally with one additional commit since the last revision:
> 
>   review comment

Looks good to me.

-------------

Marked as reviewed by dholmes (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/14720#pullrequestreview-1506312151


More information about the core-libs-dev mailing list