RFR: 8310923: Refactor Currency tests to use JUnit [v4]
Justin Lu
jlu at openjdk.org
Fri Jun 30 07:50:53 UTC 2023
On Thu, 29 Jun 2023 23:07:14 GMT, Naoto Sato <naoto at openjdk.org> wrote:
>> Justin Lu has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Remove unusued JUnit imports from ValidateISO4217.java
>
> test/jdk/java/util/Currency/MinorUndefinedCodes.java line 27:
>
>> 25: * @test
>> 26: * @bug 4512215 4818420 4819436 8310923
>> 27: * @summary Test some minor undefined currencies.
>
> It'd be more readable something like "currencies without minor units." The class name can also be renamed to something like NoMinorUnitCurrenciesTest
Adjusted the wording throughout the file according to your suggestions
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/14682#discussion_r1247547152
More information about the core-libs-dev
mailing list