RFR: 8311085: Remove implementation detail writeTo from LocalVariable(Type) [v3]

[Chen Liang]

On Fri, 30 Jun 2023 00:51:42 GMT, Chen Liang <liach at openjdk.org> wrote:

>> `LocalVariable` and `LocalVariableType` includes `writeTo(BufWriter)`, which should be implementation details.
>> 
>> See https://mail.openjdk.org/pipermail/classfile-api-dev/2023-June/000381.html for context.
>> 
>> This patch moves the implementation to `DirectCodeBuilder`'s original use sites; the old `b.canWriteDirect` branch   is redundant, as `writeIndex`'s implementation already performs such an optimization.
>
> Chen Liang has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fix line ending, update corpus test

I will merge this one. Also during development, I found a few other issues:
1. CharacterRangeTable entry writing can be shared, and I wish to move them to this new `AttributeHelpers` as well.
2. CharacterRangeInfo has documentation errors: the ending pc is inclusive instead of exclusive, as seen in Classfile and javac implementations.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/14705#issuecomment-1614608291