RFR: 8303133: Update ProcessTools.startProcess(...) to exit early if process exit before linePredicate is printed. [v5]

David Holmes dholmes at openjdk.org
Wed Mar 1 04:23:12 UTC 2023


On Mon, 27 Feb 2023 23:11:27 GMT, Leonid Mesnik <lmesnik at openjdk.org> wrote:

>> The solution proposed by Stefan K
>> 
>> The startProcess() might wait forever for the expected line if the process exits (failed to start). It makes sense to just fail earlier in such cases.
>> 
>> The fix also move
>> 'output = new OutputAnalyzer(this.process);'
>> in method xrun() to be able to try to print them in waitFor is failed/interrupted.
>
> Leonid Mesnik has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - latch != updated
>  - message improved

We are seeing large numbers of failures after this change was integrated, so it will likely need to be backed out.

-------------

PR: https://git.openjdk.org/jdk/pull/12751


More information about the core-libs-dev mailing list