RFR: 8303040: linux PPC64le: Implementation of Foreign Function & Memory API (Preview) [v3]

Martin Doerr mdoerr at openjdk.org
Wed Mar 1 06:12:59 UTC 2023


On Tue, 28 Feb 2023 16:54:50 GMT, Jorn Vernee <jvernee at openjdk.org> wrote:

>> Martin Doerr has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Remove size restriction for structs. Add TODO for Big Endian.
>
> src/hotspot/cpu/ppc/downcallLinker_ppc.cpp line 343:
> 
>> 341: 
>> 342:   __ flush();
>> 343:   // Disassembler::decode((u_char*)start, (u_char*)__ pc(), tty);
> 
> Leftover commented code?
> 
> (note that the stub can also be disassembled with `-Xlog:foreign+downcall=trace` now)

Removed. Thanks for the hint!

> src/hotspot/cpu/ppc/upcallLinker_ppc.cpp line 356:
> 
>> 354:   }
>> 355: #endif
>> 356:   //blob->print_on(tty);
> 
> Leftover commented code?

Removed.

-------------

PR: https://git.openjdk.org/jdk/pull/12708


More information about the core-libs-dev mailing list