RFR: 8303401: Add a Vector API equalsIgnoreCase micro benchmark [v3]

Eirik Bjorsnos duke at openjdk.org
Wed Mar 1 06:34:27 UTC 2023


On Tue, 28 Feb 2023 23:55:52 GMT, Paul Sandoz <psandoz at openjdk.org> wrote:

>> Eirik Bjorsnos has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - Uppercase Thorn is 0xDE
>>  - Update 'a' to 'A' and 'z' to 'Z' in comments
>
> test/micro/org/openjdk/bench/jdk/incubator/vector/EqualsIgnoreCaseBenchmark.java line 67:
> 
>> 65:     public void scalar(Blackhole blackhole) {
>> 66:         blackhole.consume(scalarEqualsIgnoreCase(a, b, len));
>> 67:     }
> 
> If you like there is no need to explicitly use a black hole, instead declare the benchmark method to return `boolean` and return the result of the call. JMH will do the right thing. I find that a little more concise and easier to read.

This was much cleaner, thank you!

-------------

PR: https://git.openjdk.org/jdk/pull/12790


More information about the core-libs-dev mailing list