RFR: 8303266: Prefer ArrayList to LinkedList in JImageTask

Andrey Turbanov aturbanov at openjdk.org
Wed Mar 1 20:23:13 UTC 2023


On Wed, 1 Mar 2023 01:32:39 GMT, Roger Riggs <rriggs at openjdk.org> wrote:

>In choosing how you spend your time, make your efforts and the efforts of the reviewers count for something.

It's one of the reasons, why I don't create PRs with massive replacements. I carefully choose places in the code, where I think replacement is 100% safe.
In this case we have a `final` field which has only 3 simple usages. Reviewing such small PR shouldn't take more than like 15 minutes.

>If you want people to stop using LinkedList, it will be much more effective to get to say "use ArrayList instead of LinkedList" 

Not sure I agree with this one. Even presence issues/PRs like this in JDK, could be used as an argument between developers, who need to choose what's better.

-------------

PR: https://git.openjdk.org/jdk/pull/12760


More information about the core-libs-dev mailing list