RFR: 8303198: System and Runtime.exit() resilience to logging errors [v2]
David Holmes
dholmes at openjdk.org
Fri Mar 3 04:16:15 UTC 2023
On Wed, 1 Mar 2023 16:59:51 GMT, Roger Riggs <rriggs at openjdk.org> wrote:
>> Consolidate logging and handle exceptions by printing to standard error and ignoring the exception.
>> Exceptions while logging will not interfere with Runtime.exit.
>
> Roger Riggs has updated the pull request incrementally with one additional commit since the last revision:
>
> Add exit status to output when the logging fails with an exception.
I still have my doubts about the actual logging strategy and the usefulness of doing it outside the lock, but won't press it. The main thing is that `logRuntimeExit` can not throw an exception.
Thanks.
If this gets integrated then JDK-8303057 should be closed as a duplicate, at which point the entry in the ProblemList gets orphaned. If JDK-8303057 is to be closed as a duplicate of this issue, then this issue should update the ProblemList. Otherwise you need a new issue just to do the PL update (it would make no sense for JDK-8303057 to be hijacked for that).
-------------
Marked as reviewed by dholmes (Reviewer).
PR: https://git.openjdk.org/jdk/pull/12770
More information about the core-libs-dev
mailing list