RFR: JDK-8302027: Port fdlibm trig functions (sin, cos, tan) to Java [v3]

Joe Darcy darcy at openjdk.org
Fri Mar 3 06:35:42 UTC 2023


On Wed, 1 Mar 2023 15:42:08 GMT, Raffaello Giulietti <rgiulietti at openjdk.org> wrote:

>> Joe Darcy has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Add note explaining goto translation.
>
> test/jdk/java/lang/StrictMath/FdlibmTranslit.java line 867:
> 
>> 865: 
>> 866:             jz = jk;
>> 867:             while(true) {
> 
> Would it be worthwhile to add some remarks about how the C `goto` + label has been "translitted"?
> Or even add the `recompute:` label explicitly and adapt the `continue` and `break` statements inside the `while`?

Note added. I think there is a stronger case for adding the note to the transliteration port than to the mainline one.

I'm open to restructuring the looping construct for the mainline port.

-------------

PR: https://git.openjdk.org/jdk/pull/12800


More information about the core-libs-dev mailing list