RFR: JDK-8302027: Port fdlibm trig functions (sin, cos, tan) to Java [v6]
Andrey Turbanov
aturbanov at openjdk.org
Sun Mar 5 09:41:29 UTC 2023
The message from this sender included one or more files
which could not be scanned for virus detection; do not
open these files unless you are certain of the sender's intent.
----------------------------------------------------------------------
On Wed, 1 Mar 2023 14:26:44 GMT, Andrey Turbanov <aturbanov at openjdk.org> wrote:
>> Joe Darcy has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 20 commits:
>>
>> - Merge branch 'master' into JDK-8302027
>> - Add test cases with Math and StrictMath differ on a given input.
>> - Add more tests.
>> - Add note explaining goto translation.
>> - Update src/java.base/share/classes/java/lang/FdLibm.java
>>
>> Co-authored-by: Andrey Turbanov <turbanoff at gmail.com>
>> - Update src/java.base/share/classes/java/lang/FdLibm.java
>>
>> Co-authored-by: Andrey Turbanov <turbanoff at gmail.com>
>> - Update src/java.base/share/classes/java/lang/FdLibm.java
>>
>> Co-authored-by: Andrey Turbanov <turbanoff at gmail.com>
>> - Update src/java.base/share/classes/java/lang/FdLibm.java
>>
>> Co-authored-by: Andrey Turbanov <turbanoff at gmail.com>
>> - Update src/java.base/share/classes/java/lang/FdLibm.java
>>
>> Co-authored-by: Andrey Turbanov <turbanoff at gmail.com>
>> - Update src/java.base/share/classes/java/lang/FdLibm.java
>>
>> Co-authored-by: Andrey Turbanov <turbanoff at gmail.com>
>> - ... and 10 more: https://git.openjdk.org/jdk/compare/9fdbf3cf...0466a98d
>
> src/java.base/share/classes/java/lang/FdLibm.java line 166:
>
>> 164: } else { // argument reduction needed
>> 165: n = RemPio2.__ieee754_rem_pio2(x, y);
>> 166: switch(n & 3) {
>
> Suggestion:
>
> switch (n & 3) {
:(
-------------
PR: https://git.openjdk.org/jdk/pull/12800
More information about the core-libs-dev
mailing list