RFR: 8294982: Implementation of Classfile API [v43]
Adam Sotona
asotona at openjdk.org
Mon Mar 6 10:33:22 UTC 2023
On Fri, 3 Mar 2023 21:56:39 GMT, Paul Sandoz <psandoz at openjdk.org> wrote:
>> Adam Sotona has updated the pull request incrementally with three additional commits since the last revision:
>>
>> - fixed AccessFlags javadoc
>> - TransformImpl.FakeXyzTransform renamed to UnresolvedXyzTransform
>> - removed obsolete generic parameter from AbstractDirectBuilder
>
> src/java.base/share/classes/jdk/internal/classfile/impl/AttributeHolder.java line 73:
>
>> 71: if (a.attributeMapper() == am)
>> 72: iterator.remove();
>> 73: }
>
> Suggestion:
>
> attributes.removeIf(a -> a.attributeMappter() == am);
>
> But presumably use an inner class instead. I can understand because of that if you want to keep the existing code instead.
It seems to be OK to use lambda here (not on critical JDK bootstrap path), thanks.
-------------
PR: https://git.openjdk.org/jdk/pull/10982
More information about the core-libs-dev
mailing list