RFR: JDK-8302360 Atomic*.compareAndExchange Javadoc unclear

David Holmes dholmes at openjdk.org
Tue Mar 7 02:47:16 UTC 2023


On Mon, 6 Mar 2023 13:23:59 GMT, Viktor Klang <duke at openjdk.org> wrote:

> I think the following proposal is very non-invasive and merely draws attention to the fact that "witness value" is a specific term related to the notion of these atomic methods.
> 
> It's a small change which I think provides additional clarity, see JBS for the discussion on the topic.

Changes requested by dholmes (Reviewer).

src/java.base/share/classes/java/util/concurrent/atomic/AtomicReference.java line 357:

> 355:      * @param newValue the new value
> 356:      * @return the <em>witness value</em>, which is the current value
> 357:      * at the time of the operation.

This change is not appropriate as discussed in JBS. And unclear why you changed only this version? Leftover?

-------------

PR: https://git.openjdk.org/jdk/pull/12880


More information about the core-libs-dev mailing list