RFR: JDK-8303794: IEEEremainder problems are causing test failures after JDK-8302801

Raffaello Giulietti rgiulietti at openjdk.org
Wed Mar 8 12:07:17 UTC 2023


On Wed, 8 Mar 2023 01:30:58 GMT, Joe Darcy <darcy at openjdk.org> wrote:

> Quick port of IEEEremainder; sorry for missing this earlier. Will add targeted tests in a follow-up fix.

src/java.base/share/classes/java/lang/FdLibm.java line 3367:

> 3365:             /* purge off exception values */
> 3366:             if((hy|ly)==0||(hx>=0x7ff00000)||       /* y=0,or x not finite */
> 3367:                ((hy|((ly | -ly) >> 31))>0x7ff00000))     /* or y is NaN */

Should be `>>>`

src/java.base/share/classes/java/lang/FdLibm.java line 3436:

> 3434:             if((hx|lx)==0)                  /* return sign(x)*0 */
> 3435:                 return Zero[sx>>>31]; // unsigned shift
> 3436:             while(Integer.compareUnsigned(hx, 0x00100000) < 0) {          /* normalize x */

Should be `hx < 0x00100000`

-------------

PR: https://git.openjdk.org/jdk/pull/12915


More information about the core-libs-dev mailing list