RFR: 8303392: Runtime.exec and ProcessBuilder.start should use System logger [v2]

Roger Riggs rriggs at openjdk.org
Thu Mar 9 20:42:17 UTC 2023


On Sun, 5 Mar 2023 06:14:49 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

>> Roger Riggs has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Add javadoc @implNote to Runtime.exec and ProcessBuilder methods
>
> Hi Roger,
> 
> I think to be even more useful it could make sense to print the current directory the child is started in as well as the env var array, possibly only with a finer logging level.
> 
> Cheers, Thomas

@tstuefe 
> I think to be even more useful it could make sense to print the current directory the child is started in as well as the env var array, possibly only with a finer logging level.

The environment is potentially bulky and may also contain sensitive information.
It is unlikely to change betwen calls to PB.start() so it doesn't add much to log it.
The logging should focus on the context and arguments of each call.

-------------

PR: https://git.openjdk.org/jdk/pull/12862


More information about the core-libs-dev mailing list