RFR: 8303392: Runtime.exec and ProcessBuilder.start should use System logger [v4]

Alan Bateman alanb at openjdk.org
Fri Mar 10 08:09:15 UTC 2023


On Fri, 10 Mar 2023 00:01:51 GMT, Roger Riggs <rriggs at openjdk.org> wrote:

>> Runtime.exec and ProcessBuilder.start methods create a new operating system process with the program and arguments. Many applications configure a logging subsystem to monitor application events. Logging a process start message with the program, arguments, and stack trace can identify the caller and purpose.
>> Logging the process start event is complementary to the process start event generated for JFR (Java Flight Recorder).
>
> Roger Riggs has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Reorder pid, directory, args in logged message.
>   Cleanup argument lists in tests.

src/java.base/share/classes/java/lang/Runtime.java line 353:

> 351:      *
> 352:      * @implNote
> 353:      * The new process creation is logged by {@link ProcessBuilder#start()}.

I agree it is useful to have an implNote here but I don't think it words to just say that it is logged by PB.start. Instead I think it should say that the process created is logged, see PB.start for details.

-------------

PR: https://git.openjdk.org/jdk/pull/12862


More information about the core-libs-dev mailing list