RFR: 8303920: Avoid calling out to python in DataDescriptorSignatureMissing test [v3]
Eirik Bjorsnos
duke at openjdk.org
Fri Mar 10 08:33:16 UTC 2023
On Fri, 10 Mar 2023 08:14:56 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:
>> Eirik Bjorsnos has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Use "Signatureless" consistently
>
> test/jdk/java/util/zip/DataDescriptorSignatureMissing.java line 2:
>
>> 1: /*
>> 2: * Copyright 2012, 2023 Google, Inc. All Rights Reserved.
>
> It's my understanding that unless you are doing this change on behalf of Google, you shouldn't be changing that line. Instead, one has to add another line below that, of the form:
>
> Copyright (c) 2023, Oracle and/or its affiliates. All rights reserved.
I have no affiliation to Google. I reverted the change to their copyright line and added an Oracle one.
There is very little code left from Martin here (the Zip64 note in the header, the class name and some whitespace), but let's keep it anyhow.
-------------
PR: https://git.openjdk.org/jdk/pull/12959
More information about the core-libs-dev
mailing list