RFR: 8294962: java.base jdk.internal.module package uses ASM to modify and write module-info.class [v2]

Alan Bateman alanb at openjdk.org
Fri Mar 10 08:46:19 UTC 2023


On Fri, 10 Mar 2023 07:10:11 GMT, Adam Sotona <asotona at openjdk.org> wrote:

>> 8294962: java.base jdk.internal.module package uses ASM to modify and write module-info.class.
>> This patch converts it to use Classfile API.
>> 
>> Please review.
>> Thanks,
>> Adam
>
> Adam Sotona has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Update src/java.base/share/classes/jdk/internal/module/ModuleInfoExtender.java
>   
>   Co-authored-by: Mandy Chung <mandy.chung at oracle.com>

Maybe it is time to move ModuleInfoWriter to test/lib? I don't think it used by any of the tools now. The tools (jlink, jar, jmod) do use ModuleInfoExtender of course.

-------------

PR: https://git.openjdk.org/jdk/pull/11368


More information about the core-libs-dev mailing list