RFR: 8294962: java.base jdk.internal.module package uses ASM to modify and write module-info.class [v3]
Adam Sotona
asotona at openjdk.org
Fri Mar 10 08:46:25 UTC 2023
On Thu, 9 Mar 2023 19:41:28 GMT, liach <duke at openjdk.org> wrote:
>> Adam Sotona has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 198 commits:
>>
>> - ModuleInfoWriter fixes
>> - ModuleInfoExtender comment fix
>> - Merge branch 'master' into JDK-8294962-internal-module
>> - Update src/java.base/share/classes/jdk/internal/module/ModuleInfoExtender.java
>>
>> Co-authored-by: Mandy Chung <mandy.chung at oracle.com>
>> - Merge branch 'master' into JDK-8294962-internal-module
>> - fixed jdk.internal.classfile.java.lang.constant package name
>> - Merge branch 'JDK-8294982' into JDK-8294962
>> - removed obsolete javadoc from implementation classes
>> - minor fix in CodeBuilder and added test cases to LDCTest
>> - EntryMap::nextPowerOfTwo delegates to Long:numberOfLeadingZeros
>> - ... and 188 more: https://git.openjdk.org/jdk/compare/e26cc526...9e366fbd
>
> src/java.base/share/classes/jdk/internal/module/ModuleInfoWriter.java line 89:
>
>> 87:
>> 88: int moduleFlags = md.modifiers().stream()
>> 89: .map(MODULE_MODS_TO_FLAGS::get)
>
> The `MODULE_MODS_TO_FLAGS` can be reused in `modifiersToFlags`. Otherwise, it's useless and can be removed.
`modifiersToFlags` method is now directly inlined using `MODULE_MODS_TO_FLAGS` stream mapping
Thank you.
-------------
PR: https://git.openjdk.org/jdk/pull/11368
More information about the core-libs-dev
mailing list