RFR: 8303920: Avoid calling out to python in DataDescriptorSignatureMissing test [v4]
Eirik Bjorsnos
duke at openjdk.org
Fri Mar 10 08:48:04 UTC 2023
On Fri, 10 Mar 2023 08:28:37 GMT, Eirik Bjorsnos <duke at openjdk.org> wrote:
>> Please review this PR which brings the DataDescriptorSignatureMissing test back to life.
>>
>> This test currently calls out to Python to create a test vector ZIP with a Data Descriptor without the recommended but optional signature. The Python dependency has turned out to be very brittle, so the test is currently marked with `@ignore`
>>
>> The PR replaces Python callouts with directly creating the test vector ZIP in the test itself. We can then remove the `@ignore`tag and run this useful test automatically.
>
> Eirik Bjorsnos has updated the pull request incrementally with one additional commit since the last revision:
>
> Revert change to Google copyright line, add an Oracle copyright line instead.
Nice! I added your assertNotNulls and tested with the off-by-one code which gives me the following:
test DataDescriptorSignatureMissing.shouldParseSignaturelessDescriptor(): failure
java.lang.AssertionError: Zip file is unexpectedly missing second entry expected object to not be null
-------------
PR: https://git.openjdk.org/jdk/pull/12959
More information about the core-libs-dev
mailing list