RFR: 8303920: Avoid calling out to python in DataDescriptorSignatureMissing test [v5]
Jaikiran Pai
jpai at openjdk.org
Fri Mar 10 09:18:09 UTC 2023
On Fri, 10 Mar 2023 08:48:00 GMT, Eirik Bjorsnos <duke at openjdk.org> wrote:
>> Please review this PR which brings the DataDescriptorSignatureMissing test back to life.
>>
>> This test currently calls out to Python to create a test vector ZIP with a Data Descriptor without the recommended but optional signature. The Python dependency has turned out to be very brittle, so the test is currently marked with `@ignore`
>>
>> The PR replaces Python callouts with directly creating the test vector ZIP in the test itself. We can then remove the `@ignore`tag and run this useful test automatically.
>
> Eirik Bjorsnos has updated the pull request incrementally with one additional commit since the last revision:
>
> Add assertNotNulls to catch unexpectedly missing entries
This now looks good to me. Thank you for doing these changes. I'll run this test on our CI just to be sure there isn't any obvious issues.
Before integrating, please wait for another review from Lance or others who have more knowledge of this area.
-------------
Marked as reviewed by jpai (Reviewer).
PR: https://git.openjdk.org/jdk/pull/12959
More information about the core-libs-dev
mailing list