RFR: 8303891: Zip64SizeTest could use a sparse file [v4]
Eirik Bjorsnos
duke at openjdk.org
Fri Mar 10 21:12:01 UTC 2023
> This PR suggests we use a sparse file when the Zip64SizeTest writes a ZIP file with a 5GB entry.
>
> The size requirement of this test is known to cause problems in some builds, see [JDK-8259866](https://bugs.openjdk.org/browse/JDK-8259866)
>
> Using a sparse file reduces the disk space requirements of running the test from 5GB to 12K and also reduces the runtime from ~35 seconds to ~3 seconds on my Macbook Pro.
Eirik Bjorsnos has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains eight additional commits since the last revision:
- Sparse files must be created explicitly on NTFS
- Merge branch 'master' into zip64-size-test-sparse
- Merge branch 'master' into zip64-size-test-sparse
- Make test method public
- Add a missing "when" in Javadocs for SparseOutputStream
- Remove introduced blank line
- Remove double whitespace
- Rewrite Zip64SizeTest to write to a sparse file
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/12948/files
- new: https://git.openjdk.org/jdk/pull/12948/files/883f543f..adcca52c
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=12948&range=03
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=12948&range=02-03
Stats: 8146 lines in 184 files changed: 1024 ins; 1302 del; 5820 mod
Patch: https://git.openjdk.org/jdk/pull/12948.diff
Fetch: git fetch https://git.openjdk.org/jdk pull/12948/head:pull/12948
PR: https://git.openjdk.org/jdk/pull/12948
More information about the core-libs-dev
mailing list