RFR: 8303040: linux PPC64le: Implementation of Foreign Function & Memory API (Preview) [v3]
Jorn Vernee
jvernee at openjdk.org
Sat Mar 11 02:23:25 UTC 2023
On Fri, 3 Mar 2023 10:59:32 GMT, Martin Doerr <mdoerr at openjdk.org> wrote:
>> Thanks! I need to find extra time for this. Sounds like a good idea and I may be able to get rid of some nasty code.
>
> Done by https://github.com/openjdk/jdk/pull/12708/commits/98e242c24c07ea977b7709b9f8d0c10ce87e84c0 (using a record instead of a `VMStorage[][]` because I think this is better readable). Note that it's a bit more complicated. I couldn't use your `dup` trick, because I need to put the value into a GP reg and one half of it to a FP reg. The Panama code doesn't support that (IllegalArgumentException: Invalid operand type: interface java.lang.foreign.MemorySegment. float expected).
Thanks, your solution looks good.
-------------
PR: https://git.openjdk.org/jdk/pull/12708
More information about the core-libs-dev
mailing list