RFR: 8304006: jlink should create the jimage file in the native endian for the target platform [v2]

[Jaikiran Pai]

On Sat, 11 Mar 2023 10:40:19 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:

>> Can I please get a review for this change which proposes to fix the issue reported in https://bugs.openjdk.org/browse/JDK-8206890?
>> 
>> The `jlink` command allows a `--endian` option to specify the byte order in the generated image. Before this change, when such a image was being launched, the code would assume the byte order in the image to be the native order of the host where the image is being launched. That would result in failure to launch java, as noted in the linked issue.
>> 
>> The commit in this PR, changes relevant places to not assume native order and instead determine the byte order by reading the magic bytes in the image file's header content.
>> 
>> A new jtreg test has been added which reproduces the issue and verifies the fix.
>
> Jaikiran Pai has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 10 additional commits since the last revision:
> 
>  - Infer endianness for the generated image from the target platform
>  - Revert "8206890: jlink --endian XXX generates unusable image if endian-ness does not match architecture"
>    
>    This reverts commit 4020a37849d04d0638941b36c8953884b933461e.
>  - Revert "take into account SecurityManager checks"
>    
>    This reverts commit 1694f3a02cf470ac3aaef5d8cdeb0a40c0c66b12.
>  - Revert "Alan's input - remove "final" and match the current code style"
>    
>    This reverts commit 7a754a1bcd20f02da33a9f5d3d170ead0675d33c.
>  - Revert "fix jcheck issue - convert tab to space"
>    
>    This reverts commit 2422399094862718ed8e0e9d3de77d9396283fa4.
>  - merge latest master branch
>  - fix jcheck issue - convert tab to space
>  - Alan's input - remove "final" and match the current code style
>  - take into account SecurityManager checks
>  - 8206890: jlink --endian XXX generates unusable image if endian-ness does not match architecture

I've updated the PR title to now point to the new https://bugs.openjdk.org/browse/JDK-8304006

-------------

PR: https://git.openjdk.org/jdk/pull/11943