RFR: 8303922: build-test-lib target is broken
Julian Waters
jwaters at openjdk.org
Sat Mar 11 18:43:22 UTC 2023
On Thu, 9 Mar 2023 20:09:46 GMT, Eirik Bjorsnos <duke at openjdk.org> wrote:
> The Make target 'build-test-lib-target' is broken in a few ways:
>
> - make/test/BuildTestLib.gmk references the directory $(TEST_LIB_SOURCE_DIR)/sun which does not seem to exist. This can be fixed by removing the reference.
> - Some test-lib sources use preview-features which is not enabled by make/test/BuildTestLib.gmk. This is fixed by adding a JAVAC_FLAGS with --enable-preview and also adding 'preview' to DISABLED_WARNINGS
> - ASN1Formatter.annotate has a possible lossy conversion from long to int which can be fixed by adding an explicit cast
>
> This PR fixes the above issues.
Marked as reviewed by jwaters (Committer).
Looks ok to me, good work :)
-------------
PR: https://git.openjdk.org/jdk/pull/12960
More information about the core-libs-dev
mailing list