RFR: 8303814: getLastErrorString should avoid charset conversions [v2]
Daniel Jeliński
djelinski at openjdk.org
Mon Mar 13 16:01:05 UTC 2023
On Mon, 13 Mar 2023 15:05:04 GMT, Roger Riggs <rriggs at openjdk.org> wrote:
>> Daniel Jeliński has updated the pull request incrementally with three additional commits since the last revision:
>>
>> - Address review comments
>> - Mention that the returned text is static and thread safe
>> - Define buffer size
>
> src/java.base/share/native/libzip/zip_util.c line 812:
>
>> 810:
>> 811: if (strlen(name) >= PATH_MAX) {
>> 812: if (pmsg) {
>
> Some pre-existing references to pmsg still use implicit comparison, though not material to this PR, can you update them to compare with NULL.
done.
-------------
PR: https://git.openjdk.org/jdk/pull/12922
More information about the core-libs-dev
mailing list