RFR: 8294962: Convert java.base/jdk.internal.module package to use the Classfile API to modify and write module-info.class [v4]

Alan Bateman alanb at openjdk.org
Mon Mar 13 18:49:47 UTC 2023


On Mon, 13 Mar 2023 17:15:21 GMT, Adam Sotona <asotona at openjdk.org> wrote:

> I see, I'll move the "packages magic" back from Classfile API to the `ModuleInfoWriter` and correct the API accordingly.

I would need to check the history in the jake repo but I think it dates from a prototype version of that attribute that only listed the concealed packages. I think it should be okay to just drop this from ModuleInfoWriter now. As I mentioned in another comment, the only user now is tests so you should able to just remove this code so that it doesn't generate the ModulePackages attributes.

-------------

PR: https://git.openjdk.org/jdk/pull/11368


More information about the core-libs-dev mailing list