RFR: 8294962: Convert java.base/jdk.internal.module package to use the Classfile API to modify and write module-info.class [v5]
Adam Sotona
asotona at openjdk.org
Tue Mar 14 12:55:38 UTC 2023
> 8294962: java.base jdk.internal.module package uses ASM to modify and write module-info.class.
> This patch converts it to use Classfile API.
>
> Please review.
> Thanks,
> Adam
Adam Sotona has updated the pull request incrementally with five additional commits since the last revision:
- fixed ModuleDescriptorTest::testReadsWithBadPackageFinder to use Classfile API directly to generate modules descriptor without ModulePackagesAttribute
- ModuleInfoWriter converted to support invalid module names and emit ModulePackagesAttribute if packages are provided
- fixed Classfile API tests
- added ModuleAttribute::of(ModuleEntry, Consumer<ModuleAttributeBuilder>)
- removed obsolete Classfile.buildModule method argument List<PackageDesc> and obsolete method overrides
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/11368/files
- new: https://git.openjdk.org/jdk/pull/11368/files/089220bc..da280b0b
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=11368&range=04
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=11368&range=03-04
Stats: 134 lines in 7 files changed: 41 ins; 50 del; 43 mod
Patch: https://git.openjdk.org/jdk/pull/11368.diff
Fetch: git fetch https://git.openjdk.org/jdk pull/11368/head:pull/11368
PR: https://git.openjdk.org/jdk/pull/11368
More information about the core-libs-dev
mailing list