RFR: 8303431: [JVMCI] libgraal annotation API [v5]

Doug Simon dnsimon at openjdk.org
Tue Mar 14 15:56:48 UTC 2023


On Tue, 14 Mar 2023 06:28:20 GMT, Tom Rodriguez <never at openjdk.org> wrote:

>> Doug Simon has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains seven commits:
>> 
>>  - Merge remote-tracking branch 'openjdk-jdk/master' into JDK-8303431
>>  - switched to use of lists and maps instead of arrays
>>  - fixed whitespace
>>  - added support for inherited annotations
>>  - Merge branch 'master' into JDK-8303431
>>  - made AnnotationDataDecoder package-private
>>  - add annotation API to JVMCI
>
> src/hotspot/share/jvmci/jvmciCompilerToVM.cpp line 2699:
> 
>> 2697:   typeArrayOop ba = typeArrayOop(res);
>> 2698:   int ba_len = ba->length();
>> 2699:   if (ba_len <= 256) {
> 
> Is this really necessary?  Resource allocation is very cheap.

Ok, good point. I'll remove the optimization.

-------------

PR: https://git.openjdk.org/jdk/pull/12810


More information about the core-libs-dev mailing list