RFR: 8303697: ProcessTools doesn't print last line of process output [v3]
Thomas Stuefe
stuefe at openjdk.org
Thu Mar 16 06:22:21 UTC 2023
On Wed, 15 Mar 2023 22:49:57 GMT, Leonid Mesnik <lmesnik at openjdk.org> wrote:
>> The StreamPumper is fixed to process the last line even it is not finishes with '\n' or '\r'. The test included. Testing with tier1-3 also to verify that tests are not broken.
>
> Leonid Mesnik has updated the pull request incrementally with one additional commit since the last revision:
>
> comments added
That also affects OutputAnalyzer, right? Does this affect parsing or is this only printing?
Anyway, patch looks good to me, modulo of what David wrote. If you fix his remarks, its good to me.
-------------
Marked as reviewed by stuefe (Reviewer).
PR: https://git.openjdk.org/jdk/pull/13034
More information about the core-libs-dev
mailing list