RFR: 8303040: linux PPC64le: Implementation of Foreign Function & Memory API (Preview) [v16]
Martin Doerr
mdoerr at openjdk.org
Thu Mar 16 08:36:39 UTC 2023
On Tue, 14 Mar 2023 22:52:44 GMT, Martin Doerr <mdoerr at openjdk.org> wrote:
>> Martin Doerr has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Fix storing 32 bit integers into Java frames. Enable TestArrayStructs.
>
> Btw. the new cases in which we use int and short accesses when byteWidth is not a power of 2 are never unaligned AFAICS. I guess _UNALIGNED is unnecessary in the JAVA_INT_UNALIGNED and JAVA_SHORT_UNALIGNED. They are always aligned wrt. to their size.
> @TheRealMDoerr I've approved the PR. I suggest for a second reviewer to try and get someone who knows the PPC port.
Thanks for the review! I guess I should also wait for your 2 PRs to be integrated, so I can merge and adapt.
-------------
PR: https://git.openjdk.org/jdk/pull/12708
More information about the core-libs-dev
mailing list