RFR: JDK-8304063: tools/jpackage/share/AppLauncherEnvTest.java fails when checking LD_LIBRARY_PATH [v2]

[Matthias Baesken]

On Wed, 15 Mar 2023 18:37:51 GMT, Alexey Semenyuk <asemenyuk at openjdk.org> wrote:

>> Matthias Baesken has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   redo check
>
> test/jdk/tools/jpackage/share/AppLauncherEnvTest.java line 93:
> 
>> 91:         } else {
>> 92:             TKit.assertEquals(expectedEnvVarValue, actualEnvVarValue, msg);
>> 93:         }
> 
> I'd keep the check as a single statement:
> 
> TKit.assertTextStream(expectedEnvVarValue)
>     .predicate(TKit.isLinux() ? String::endsWith : String::equals)
>     .label(String.format("value of %s env variable", envVarName))
>     .apply(Stream.of(actualEnvVarValue));
> 
> 
> It also will produce a nicer log record than `TKit.assertTrue(false, msg);`

Hi Alexey, I adjusted the check following your advice .

-------------

PR: https://git.openjdk.org/jdk/pull/13041