RFR: JDK-8303742: CompletableFuture.orTimeout leaks if the future completes exceptionally [v6]

Viktor Klang duke at openjdk.org
Fri Mar 17 09:52:51 UTC 2023


> Addresses the situation where exceptional completion of `orTimeout`:ed CompletableFutures wouldn't cancel the timeout task which could lead to memory leaks if done frequently enough with long enough timeout durations.
> 
> Fix discussed with @DougLea

Viktor Klang has updated the pull request incrementally with one additional commit since the last revision:

  Reformatting the while-body to be more legible in diffs, and inlining the counter incrementation.

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/13059/files
  - new: https://git.openjdk.org/jdk/pull/13059/files/71b67aea..80680bee

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=13059&range=05
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=13059&range=04-05

  Stats: 8 lines in 1 file changed: 2 ins; 0 del; 6 mod
  Patch: https://git.openjdk.org/jdk/pull/13059.diff
  Fetch: git fetch https://git.openjdk.org/jdk pull/13059/head:pull/13059

PR: https://git.openjdk.org/jdk/pull/13059


More information about the core-libs-dev mailing list