RFR: 8294972: Convert jdk.jlink internal plugins to use the Classfile API [v10]

Adam Sotona asotona at openjdk.org
Fri Mar 17 11:44:15 UTC 2023


On Thu, 16 Mar 2023 21:49:28 GMT, Mandy Chung <mchung at openjdk.org> wrote:

>> Adam Sotona has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   remaining cleanup in SystemModulesPlugin
>
> src/jdk.jlink/share/classes/jdk/tools/jlink/internal/plugins/SystemModulesPlugin.java line 79:
> 
>> 77: import jdk.internal.classfile.ClassBuilder;
>> 78: import jdk.internal.classfile.Classfile;
>> 79: import jdk.internal.classfile.Opcode;
> 
> this import is unused now.

fixed, thanks.

> src/jdk.jlink/share/classes/jdk/tools/jlink/internal/plugins/SystemModulesPlugin.java line 577:
> 
>> 575:          * Generate SystemModules class
>> 576:          */
>> 577:         public byte[] getClassWriter(Configuration cf) {
> 
> This method no longer returns a class writer and should be renamed.   What about `genClassBytes`?

renamed to `genClassBytes` as proposed, thanks.

-------------

PR: https://git.openjdk.org/jdk/pull/12944


More information about the core-libs-dev mailing list