RFR: 8294972: Convert jdk.jlink internal plugins to use the Classfile API [v12]
Mandy Chung
mchung at openjdk.org
Fri Mar 17 17:34:24 UTC 2023
On Fri, 17 Mar 2023 17:01:43 GMT, Adam Sotona <asotona at openjdk.org> wrote:
>> jdk.jlink internal plugins are heavily using ASM
>>
>> This patch converts ASM calls to Classfile API.
>>
>> Please review.
>> Thanks,
>> Adam
>
> Adam Sotona has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 220 commits:
>
> - Merge branch 'master' into JDK-8294972-jlink-plugins
> - SystemModulesPlugin::genClassBytes rename
> - SystemModulesPlugin::getClassBytes rename
> - Revert "implementation of custom ResourceHelper in IncludeLocalesPlugin"
> - remaining cleanup in SystemModulesPlugin
> - implementation of custom ResourceHelper in IncludeLocalesPlugin
> - fixed SystemModulesPlugin
> - fixed StripJavaDebugAttribute to drop line numbers from code
> - long lines wrapped
> - StripJavaDebugAttributesPlugin transformation fixed
> - ... and 210 more: https://git.openjdk.org/jdk/compare/4486f1b7...4e5b9651
src/jdk.jlink/share/classes/jdk/tools/jlink/internal/plugins/IncludeLocalesPlugin.java line 309:
> 307: TAG_INVOKEDYNAMIC -> offset += 5;
> 308: case TAG_LONG,
> 309: TAG_DOUBLE -> {offset += 9; cpSlot++;} //additional slot for double and long entries
should this add the default case and throw to prepare for future change?
-------------
PR: https://git.openjdk.org/jdk/pull/12944
More information about the core-libs-dev
mailing list