RFR: 8303923: ZipOutStream::putEntry should include an apiNote to indicate that the STORED compression method should be used when writing directory entries [v3]

Eirik Bjorsnos duke at openjdk.org
Sun Mar 19 14:50:41 UTC 2023


> ZipOutputStream currently writes directory entries using the DEFLATED compression method. This does not strictly comply with the APPNOTE.TXT specification and is also about 10x slower than using the STORED compression method.
> 
> Because of these concerns, `ZipOutputStream.putNextEntry` should be updated with an `@apiNote` recommending
> the use of the STORED compression method for directory entries.
> 
> Suggested CSR in the first comment.

Eirik Bjorsnos has updated the pull request incrementally with one additional commit since the last revision:

  Remove speculation that using DEFLATED for directory entries is not in strict compliance with APPNOTE.txt

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/12899/files
  - new: https://git.openjdk.org/jdk/pull/12899/files/864a0887..24d2afc2

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=12899&range=02
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=12899&range=01-02

  Stats: 3 lines in 1 file changed: 0 ins; 1 del; 2 mod
  Patch: https://git.openjdk.org/jdk/pull/12899.diff
  Fetch: git fetch https://git.openjdk.org/jdk pull/12899/head:pull/12899

PR: https://git.openjdk.org/jdk/pull/12899


More information about the core-libs-dev mailing list