RFR: 8294972: Convert jdk.jlink internal plugins to use the Classfile API [v13]

Mandy Chung mchung at openjdk.org
Mon Mar 20 17:08:16 UTC 2023


On Mon, 20 Mar 2023 15:34:31 GMT, Alan Bateman <alanb at openjdk.org> wrote:

>> Adam Sotona has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   added default to thrown for unknown CP tag in IncludeLocalesPlugin
>
> src/jdk.jlink/share/classes/jdk/tools/jlink/internal/plugins/SystemModulesPlugin.java line 581:
> 
>> 579:                         clb.withFlags(ACC_FINAL + ACC_SUPER)
>> 580:                            .withInterfaceSymbols(List.of(CD_SYSTEM_MODULES))
>> 581:                            .withVersion(52, 0);
> 
> @mlchung Do you recall why this was generated as version 52?

When this plugin was added in JDK 9, no API to get the current class file version.  Later I added `jdk.internal.misc.VM::classFileVersion` and converted lambda proxies and lambda forms to use it.

I have a patch to switch class file version to `ClassFileFormatVersion::latest` in this generated class and some others but want to wait until this PR is integrated.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/12944#discussion_r1142415605


More information about the core-libs-dev mailing list