RFR: JDK-8285932 Implementation of JEP 430 String Templates (Preview) [v46]

[Jim Laskey]

On Wed, 22 Mar 2023 23:12:02 GMT, Chen Liang <liach at openjdk.org> wrote:

>> Jim Laskey has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - Tidy javadoc
>>  - Rename StringTemplate classes
>
> src/java.base/share/classes/java/lang/StringTemplate.java line 449:
> 
>> 447:      * statically imported explicitly.
>> 448:      */
>> 449:     static final SimpleProcessor<StringTemplate> RAW = st -> st;
> 
> Should we omit the modifiers `static final`, which are implicit for all interface fields?

Already changed.

> src/java.base/share/classes/java/lang/StringTemplate.java line 455:
> 
>> 453:      * primary method {@link Processor#process(StringTemplate)} is used to validate
>> 454:      * and compose a result using a {@link StringTemplate StringTemplate's} fragments and values lists.
>> 455:      *
> 
> Paragraph break intended here?

Changed

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/10889#discussion_r1146060615
PR Review Comment: https://git.openjdk.org/jdk/pull/10889#discussion_r1146060887