RFR: JDK-8304557: java/util/concurrent/CompletableFuture/CompletableFutureOrTimeoutExceptionallyTest.java times out [v3]

Jaikiran Pai jpai at openjdk.org
Thu Mar 23 14:30:23 UTC 2023


On Thu, 23 Mar 2023 14:13:14 GMT, Viktor Klang <duke at openjdk.org> wrote:

>> Improves the stability of the memory leak test for CompletableFuture timeout cancellation by both reducing the count by 50% (which should still be above threshold to trigger given the ample margin set initially) as well as extending the default timeout of the test run.
>
> Viktor Klang has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Adding an @modules and minor code reformatting

I don't have anything else to suggest on these changes. The latest change in `572687a` looks good to me.

If it's possible and easy to do, perhaps run this latest test changes against the debug build and machine on which it previously failed, to rule out any obvious issues?

-------------

Marked as reviewed by jpai (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/13116#pullrequestreview-1354762439


More information about the core-libs-dev mailing list