RFR: 8304013: Add a fast, non-manual alternative to test/jdk/java/util/zip/ZipFile/TestTooManyEntries [v2]
Eirik Bjorsnos
duke at openjdk.org
Sat Mar 25 06:57:32 UTC 2023
On Fri, 24 Mar 2023 16:36:46 GMT, Lance Andersen <lancea at openjdk.org> wrote:
>> Eirik Bjorsnos has updated the pull request incrementally with three additional commits since the last revision:
>>
>> - Remove @throws as per review feedback
>> - Consistently use the term "END header" when referring to the "End of central directory record".
>> - Remove "the the" repetition
>
> Mach 5 test runs are clean so you are good to go Eirik, thank you again
@LanceAndersen Would you like to do a final review after the changes suggested by Martin in his late review?
It is mostly comment changes, and some stray variable renames. I have run the test locally after the last changes, and it passes on my machine.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/12231#issuecomment-1483744996
More information about the core-libs-dev
mailing list