RFR: 8304013: Add a fast, non-manual alternative to test/jdk/java/util/zip/ZipFile/TestTooManyEntries [v2]
Lance Andersen
lancea at openjdk.org
Sat Mar 25 10:50:31 UTC 2023
On Sat, 25 Mar 2023 06:50:16 GMT, Eirik Bjorsnos <duke at openjdk.org> wrote:
>> test/jdk/java/util/zip/ZipFile/EndOfCenValidation.java line 139:
>>
>>> 137: * Validate that an end of central directory record with a CEN offset which
>>> 138: * is larger than the EOC position minus the CEN size is rejected
>>> 139: * @throws IOException
>>
>> I don't think `@throws` javadoc comments in tests are useful; especially checked ones
>
> I recently added a `@throws` by review comment from Lance. I tend to agree that is not very useful, so I'm removing both ocurrences as per your recommendation.
>
> If Lance wants it back, he can add a review comment saying so. I don't particularly care which professor gets the last word in this matter :-)
Please add them back before pushing with `@throws IOException if an error occurs`
Yes I understand they do not add much value but it will reduce noise from IDEs and if/when we add more checks for missing javadoc tags, it will save us from having to revisit this
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/12231#discussion_r1148348992
More information about the core-libs-dev
mailing list