RFR: 8304013: Add a fast, non-manual alternative to test/jdk/java/util/zip/ZipFile/TestTooManyEntries [v4]

Eirik Bjorsnos duke at openjdk.org
Sat Mar 25 12:21:31 UTC 2023


On Sat, 25 Mar 2023 12:11:18 GMT, Eirik Bjorsnos <duke at openjdk.org> wrote:

>>> I hear you but the option is not to use javadoc comments and use block comments :-)
>> 
>> I learned something new today: Javadoc comments and block comments are not the same!
>
> So I changed the references to this ultimate ZIP structure to read like this:
> 
> 'End of central directory record' (END header)
> 
> Example:
> 
> 
> /**
>      * Validate that an 'End of central directory record' (END header)
>      * where the value of the CEN size field exceeds the position of
>      * the END header is rejected.
> 
> 
> This way we stick to the 'official' ZIP verbiage but also allow using the shorter 'END header'.
> 
> What do you think?

> Either way you should not need a sponsor and should be good to integrated when you are ready

As a non-committer, I still think I need help from a committer to `/sponsor` this change, right?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/12231#discussion_r1148360373


More information about the core-libs-dev mailing list