RFR: 8304013: Add a fast, non-manual alternative to test/jdk/java/util/zip/ZipFile/TestTooManyEntries [v4]

[Martin Buchholz]

On Sat, 25 Mar 2023 10:59:36 GMT, Lance Andersen <lancea at openjdk.org> wrote:

>> If by "standard" you mean "APPNOTE.TXT", then that uses "end of central directory record" which is a bit long.
>> 
>> The Java implementation seems to use END, like in `ZipFile.ENDHDR`, "END header", etc.
>> 
>> It is probably better to be consistent than correct here, so I've changed the test to use "END header" consistently when referring to the "end of central directory record".
>
> So, what I would suggest is adding a comment somewhere regarding _end of central directory record_ and note the reference to _ENDHDR_ or _END Header_
> 
> I don't think you want to spend too much time here just the wording reference the _end of central directory record_ was clear and where you were abbreviating,  then I would reference ENDHDR
> 
> I would be looking at the APP.NOTE  when looking at this test, not the ZipFile constant verbiage, but that is just me :-)

Neither APPNOTE nor JDK doc zip  terminology is great, but a test is not the place to invent something better.

(But I'm surprised no one seems to be using "EOCD")

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/12231#discussion_r1148594475