RFR: 8294961: Convert java.base/java.lang.reflect.ProxyGenerator to use the Classfile API to generate proxy classes [v10]
Adam Sotona
asotona at openjdk.org
Mon Mar 27 08:14:27 UTC 2023
On Wed, 22 Mar 2023 17:46:37 GMT, Chen Liang <liach at openjdk.org> wrote:
>> Adam Sotona has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 201 commits:
>>
>> - Merge branch 'master' into JDK-8294961
>>
>> # Conflicts:
>> # src/java.base/share/classes/java/lang/reflect/ProxyGenerator.java
>> - ClassEntry caching ClassDesc to improve performance
>> - MethodTypeDesc performance improvements
>> - improved method descriptor construction
>> - Apply suggestions from code review
>>
>> Co-authored-by: liach <7806504+liach at users.noreply.github.com>
>> - Merge branch 'master' into JDK-8294961-proxy
>> - Merge branch 'master' into JDK-8294961-proxy
>> - Merge branch 'JDK-8294982' into JDK-8294961
>> - removed obsolete javadoc from implementation classes
>> - minor fix in CodeBuilder and added test cases to LDCTest
>> - ... and 191 more: https://git.openjdk.org/jdk/compare/a2d8f634...2787185c
>
> src/java.base/share/classes/java/lang/reflect/ProxyGenerator.java line 91:
>
>> 89:
>> 90: private static final String NAME_CTOR = "<init>";
>> 91: private static final String NAME_CLINIT = "<clinit>";
>
> Can be replaced with `ConstantDescs.INIT_NAME` and `CLASS_INIT_NAME`
fixed, thanks.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/10991#discussion_r1148940422
More information about the core-libs-dev
mailing list