RFR: 8266571: Sequenced Collections [v2]

[Stuart Marks]

On Sat, 25 Mar 2023 08:19:18 GMT, Rémi Forax <forax at openjdk.org> wrote:

>> Stuart Marks has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - More specification tweaks.
>>  - Add simple overrides to ArrayList.
>
> This change is absolutely massive, implementing reversed() basically doubles the number of implementations which means multiple years of debugging / spec fixing.
> 
> Reversing a List makes sense, reversing a LinkedHashSet/LinkedHashMap is a nice to have. Having the concept of first and last (getFirst()/getLast()/etc) on Collection is something long awaited. 
> 
> I understand that wanting to separate the concept of Collection and SequencedCollection can be conceptually nice, but 
> multiplying the number of interfaces also multiplies the number of implementations. Pragmatically, this patch is too big compared to how useful it is.
> 
> I get that Oracle is rich, but this JEP is not only a burden for Oracle but for the whole community.

@forax 

Funnily, I was thinking the other day that this change is quite small given that I've been working on it for over two years. :-)

Anyway, thanks for looking through the implementation.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/7387#issuecomment-1486016843