RFR: 8303002: Reject packed structs from linker [v2]

Jorn Vernee jvernee at openjdk.org
Tue Mar 28 23:42:22 UTC 2023


On Mon, 27 Mar 2023 14:51:28 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:

>> Jorn Vernee has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase.
>
> src/java.base/share/classes/java/lang/foreign/Linker.java line 200:
> 
>> 198:  * </table></blockquote>
>> 199:  * <p>
>> 200:  * Note that due to limited ABI specification coverage, none of the native linker implementations supports
> 
> Is there something bigger to say here? E.g. can I pass a C int with an alignment other than its size? E.g. is there a requirement that the alignment of _all_ layouts should be identical to their natural alignment? If so, we should say so.

I've added a list of constraints to the linker class javadoc which covers this.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13164#discussion_r1151250648


More information about the core-libs-dev mailing list