RFR: 8304006: jlink should create the jimage file in the native endian for the target platform [v16]

Jaikiran Pai jpai at openjdk.org
Wed Mar 29 01:42:42 UTC 2023


On Tue, 28 Mar 2023 10:57:36 GMT, Alan Bateman <alanb at openjdk.org> wrote:

>> Jaikiran Pai has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   use test.jdk system property in test
>
> src/jdk.jlink/share/classes/jdk/tools/jlink/internal/Platform.java line 39:
> 
>> 37:  */
>> 38: public record Platform(OperatingSystem os, Architecture arch, ByteOrder endianness) {
>> 39:     private static final Properties KNOWN_ENDIANNESS;
> 
> I assume this should be renamed to something like PLATFORM_PROPERTIES as the properties are not specific to endianness now.

Hello Alan, I've updated the PR with this and the other test related suggestions.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/11943#discussion_r1151308182


More information about the core-libs-dev mailing list