RFR: JDK-8304028: Port fdlibm IEEEremainder to Java [v2]
Joe Darcy
darcy at openjdk.org
Wed Mar 29 04:14:30 UTC 2023
On Mon, 27 Mar 2023 09:43:03 GMT, Raffaello Giulietti <rgiulietti at openjdk.org> wrote:
>> Joe Darcy has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
>>
>> - Respond to review feedback, expand tests.
>> - Merge branch 'master' into JDK-8304028
>> - JDK-8304028: Port fdlibm IEEEremainder to Java
>
> test/jdk/java/lang/StrictMath/FdlibmTranslit.java line 2652:
>
>> 2650: /* purge off exception values */
>> 2651: if((hy|ly)==0||(hx>=0x7ff00000)|| /* y=0,or x not finite */
>> 2652: ((hy|((ly|-ly)>>31))>0x7ff00000)) /* or y is NaN */
>
> Suggestion:
>
> ((hy|((ly|-ly)>>>31))>0x7ff00000)) /* or y is NaN */
Updated to latest push in both FdlibmTranslit and Fdlibm; thanks,
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/13113#discussion_r1151372326
More information about the core-libs-dev
mailing list