RFR: JDK-8304028: Port fdlibm IEEEremainder to Java [v3]
Joe Darcy
darcy at openjdk.org
Wed Mar 29 04:21:10 UTC 2023
> Last but not least, a port of fdlibm IEEEremainder from C to Java. I plan to write some more implementation-specific tests around decision points in the FDLIBM algorithm, but I wanted to get the bulk of the changes out for review first.
>
> Note that since IEEEremainder was the last native method in StrictMath.java, the StrictMath.c file needed to be deleted (or modified) since StrictMath.h was no longer generated as part of the build. (StrictMath.c was one of the file deleted as part of JDK-8302801).
>
> For testing, Mach 5 tier 1 through 3 were successful (other than an unrelated test failure that was problem listed) and the exhaustive test was locally run and passed with "16, 16" to increase the testing density.
Joe Darcy has updated the pull request incrementally with one additional commit since the last revision:
Appease jcheck.
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/13113/files
- new: https://git.openjdk.org/jdk/pull/13113/files/e23662a1..cce01395
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=13113&range=02
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=13113&range=01-02
Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod
Patch: https://git.openjdk.org/jdk/pull/13113.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/13113/head:pull/13113
PR: https://git.openjdk.org/jdk/pull/13113
More information about the core-libs-dev
mailing list