RFR: 8304014: Convert test/jdk/java/util/zip/ZipFile/CorruptedZipFiles.java to testNG
Eirik Bjorsnos
duke at openjdk.org
Wed Mar 29 09:32:20 UTC 2023
CorruptedZipFiles could benefit from some spring cleaning and a conversion to testNG:
- The actual tests are moved into their own `@Test` methods, given more meaningful names and a Javadoc comment explaining the constraint being verified
- The setup code is moved to a `@Before` method, slightly modernized and rewritten to take advantage of `assertEquals`
- `checkZipExceptionImpl` is updated to take advantage of `expectThrows`
- A bunch of constants copied over from `ZipFile` can be deleted since JDK-6225935 has long been fixed
-------------
Commit messages:
- Merge branch 'master' into corrupted-zip-files-ng
- Give the @BeforeMethod and @AfterMethod more meaningful names
- Improve comments and method names to help future maintainers understand what these tests verify.
- Merge branch 'master' into corrupted-zip-files-ng
- Trim whitespace and fix some spelling
- Convert test CorruptedZipFiles to testNG and delete ZipFile constants copies which are now obsolete.
Changes: https://git.openjdk.org/jdk/pull/12563/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=12563&range=00
Issue: https://bugs.openjdk.org/browse/JDK-8304014
Stats: 268 lines in 1 file changed: 89 ins; 54 del; 125 mod
Patch: https://git.openjdk.org/jdk/pull/12563.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/12563/head:pull/12563
PR: https://git.openjdk.org/jdk/pull/12563
More information about the core-libs-dev
mailing list