RFR: JDK-8304028: Port fdlibm IEEEremainder to Java [v4]
Brian Burkhalter
bpb at openjdk.org
Fri Mar 31 19:27:14 UTC 2023
On Fri, 31 Mar 2023 19:23:10 GMT, Joe Darcy <darcy at openjdk.org> wrote:
>> Last but not least, a port of fdlibm IEEEremainder from C to Java. I plan to write some more implementation-specific tests around decision points in the FDLIBM algorithm, but I wanted to get the bulk of the changes out for review first.
>>
>> Note that since IEEEremainder was the last native method in StrictMath.java, the StrictMath.c file needed to be deleted (or modified) since StrictMath.h was no longer generated as part of the build. (StrictMath.c was one of the file deleted as part of JDK-8302801).
>>
>> For testing, Mach 5 tier 1 through 3 were successful (other than an unrelated test failure that was problem listed) and the exhaustive test was locally run and passed with "16, 16" to increase the testing density.
>
> Joe Darcy has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since the last revision:
>
> - Merge branch 'master' into JDK-8304028
> - Appease jcheck.
> - Respond to review feedback, expand tests.
> - Merge branch 'master' into JDK-8304028
> - JDK-8304028: Port fdlibm IEEEremainder to Java
Marked as reviewed by bpb (Reviewer).
-------------
PR Review: https://git.openjdk.org/jdk/pull/13113#pullrequestreview-1367475092
More information about the core-libs-dev
mailing list